Quality: remove custom fallback css for 40px size (#224)

t-hamano · Oct 20, 2024 · b69cabb · b69cabb
1 parent 44a6fa2
commit b69cabb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 14 deletions.
diff --git a/src/editor.scss b/src/editor.scss
@@ -402,13 +402,6 @@
 	cursor: initial;
 }
 
-// TODO: Remove this style and replace it with `__next40pxDefaultSize` prop
-// when supported WordPress versions are greater than or equal to 6.5.
-// See: https://github.com/WordPress/gutenberg/pull/55471
-.ftb-is-next-40px-default-size .components-text-control__input {
-	height: 40px;
-}
-
 // Setting Component Styles
 .ftb-button-group {
 	display: block;

diff --git a/src/elements/table-placeholder.tsx b/src/elements/table-placeholder.tsx
@@ -166,24 +166,24 @@ export default function TablePlaceholder( { setAttributes }: Props ) {
 				</div>
 				<div className="ftb-placeholder__row">
 					<TextControl
-						className="ftb-is-next-40px-default-size"
 						label={ __( 'Column count', 'flexible-table-block' ) }
 						type="number"
 						min="1"
 						max={ MAX_PREVIEW_TABLE_COL }
 						value={ colCount || '' }
 						onChange={ onChangeColumnCount }
 						__nextHasNoMarginBottom
+						__next40pxDefaultSize
 					/>
 					<TextControl
-						className="ftb-is-next-40px-default-size"
 						label={ __( 'Row count', 'flexible-table-block' ) }
 						type="number"
 						min="1"
 						max={ MAX_PREVIEW_TABLE_ROW }
 						value={ rowCount || '' }
 						onChange={ onChangeRowCount }
 						__nextHasNoMarginBottom
+						__next40pxDefaultSize
 					/>
 					<Button
 						variant="primary"

diff --git a/src/settings/table-caption-settings.tsx b/src/settings/table-caption-settings.tsx
@@ -127,7 +127,6 @@ export default function TableCaptionSettings( {
 					__nextHasNoMarginBottom
 				>
 					<TextControl
-						className="ftb-is-next-40px-default-size"
 						label={ __( 'Caption line height', 'flexible-table-block' ) }
 						autoComplete="off"
 						onChange={ onChangeLineHeight }
@@ -136,6 +135,7 @@ export default function TableCaptionSettings( {
 						value={ captionStylesObj?.lineHeight || '' }
 						min={ 0 }
 						__nextHasNoMarginBottom
+						__next40pxDefaultSize
 					/>
 				</BaseControl>
 			</div>

diff --git a/src/settings/table-cell-settings.tsx b/src/settings/table-cell-settings.tsx
@@ -244,7 +244,6 @@ export default function TableCellSettings( { setAttributes, vTable, selectedCell
 					__nextHasNoMarginBottom
 				>
 					<TextControl
-						className="ftb-is-next-40px-default-size"
 						label={ __( 'Cell line height', 'flexible-table-block' ) }
 						value={ cellStylesObj?.lineHeight || '' }
 						autoComplete="off"
@@ -253,6 +252,7 @@ export default function TableCellSettings( { setAttributes, vTable, selectedCell
 						min={ 0 }
 						onChange={ onChangeLineHeight }
 						__nextHasNoMarginBottom
+						__next40pxDefaultSize
 					/>
 				</BaseControl>
 			</div>
@@ -395,20 +395,19 @@ export default function TableCellSettings( { setAttributes, vTable, selectedCell
 				) ) }
 			</ToggleGroupControl>
 			<TextControl
-				className="ftb-is-next-40px-default-size"
 				label={ __( 'Cell CSS class(es)', 'flexible-table-block' ) }
 				autoComplete="off"
 				value={ targetCell.className || '' }
 				onChange={ onChangeClass }
 				help={ __( 'Separate multiple classes with spaces.', 'flexible-table-block' ) }
 				__nextHasNoMarginBottom
+				__next40pxDefaultSize
 			/>
 			{ selectedCellTags.length === 1 && (
 				<>
 					<hr />
 					{ selectedCellTags.includes( 'th' ) && (
 						<TextControl
-							className="ftb-is-next-40px-default-size"
 							label={ createInterpolateElement(
 								__( '<code>id</code> attribute', 'flexible-table-block' ),
 								{ code: <code /> }
@@ -417,10 +416,10 @@ export default function TableCellSettings( { setAttributes, vTable, selectedCell
 							value={ targetCell.id || '' }
 							onChange={ onChangeId }
 							__nextHasNoMarginBottom
+							__next40pxDefaultSize
 						/>
 					) }
 					<TextControl
-						className="ftb-is-next-40px-default-size"
 						label={ createInterpolateElement(
 							__( '<code>headers</code> attribute', 'flexible-table-block' ),
 							{ code: <code /> }
@@ -429,6 +428,7 @@ export default function TableCellSettings( { setAttributes, vTable, selectedCell
 						value={ targetCell.headers || '' }
 						onChange={ onChangeHeaders }
 						__nextHasNoMarginBottom
+						__next40pxDefaultSize
 					/>
 					{ selectedCellTags.includes( 'th' ) && (
 						<BaseControl id="flexible-table-block-cell-scope" __nextHasNoMarginBottom>