Quality: remove unused allowSides prop (#217)

t-hamano · Oct 20, 2024 · 51915ec · 51915ec
1 parent 84ed103
commit 51915ec
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 55 deletions.
diff --git a/src/controls/border-color-control.tsx b/src/controls/border-color-control.tsx
@@ -39,7 +39,6 @@ type Props = {
 		bottom?: Property.BorderBottomColor;
 		left?: Property.BorderLeftColor;
 	};
-	allowSides?: boolean;
 	hasIndicator?: boolean;
 };
 
@@ -56,17 +55,18 @@ export default function BorderColorControl( {
 	help,
 	onChange,
 	values: valuesProp,
-	allowSides = true,
 	hasIndicator = true,
 }: Props ) {
 	const values = {
 		...DEFAULT_VALUES,
 		...valuesProp,
 	};
 
-	const isMixed: boolean =
-		allowSides &&
-		! ( values.top === values.right && values.top === values.bottom && values.top === values.left );
+	const isMixed: boolean = ! (
+		values.top === values.right &&
+		values.top === values.bottom &&
+		values.top === values.left
+	);
 
 	const colors = useSelect( ( select ) => {
 		const settings = select(
@@ -132,7 +132,7 @@ export default function BorderColorControl( {
 				</div>
 				<div className="ftb-border-color-control__controls">
 					<div className="ftb-border-color-control__controls-inner">
-						{ ( isLinked || ! allowSides ) && (
+						{ isLinked && (
 							<div className="ftb-border-color-control__controls-row">
 								{ hasIndicator && <SideIndicatorControl /> }
 								<Button
@@ -166,7 +166,6 @@ export default function BorderColorControl( {
 							</div>
 						) }
 						{ ! isLinked &&
-							allowSides &&
 							SIDE_CONTROLS.map( ( item, index ) => (
 								<div className="ftb-border-color-control__controls-row" key={ index }>
 									{ hasIndicator && <SideIndicatorControl sides={ [ item.value ] } /> }
@@ -196,15 +195,13 @@ export default function BorderColorControl( {
 								</div>
 							) ) }
 					</div>
-					{ allowSides && (
-						<Button
-							className="ftb-border-color-control__header-linked-button"
-							label={ linkedLabel }
-							onClick={ toggleLinked }
-							icon={ isLinked ? link : linkOff }
-							size="small"
-						/>
-					) }
+					<Button
+						className="ftb-border-color-control__header-linked-button"
+						label={ linkedLabel }
+						onClick={ toggleLinked }
+						icon={ isLinked ? link : linkOff }
+						size="small"
+					/>
 				</div>
 			</div>
 		</BaseControl>

diff --git a/src/controls/border-radius-control.tsx b/src/controls/border-radius-control.tsx
@@ -43,7 +43,6 @@ type Props = {
 		bottomRight?: Property.BorderBottomRightRadius;
 		bottomLeft?: Property.BorderBottomLeftRadius;
 	};
-	allowSides?: boolean;
 	hasIndicator?: boolean;
 };
 
@@ -56,21 +55,18 @@ export default function BorderRadiusControl( {
 	help,
 	onChange,
 	values: valuesProp,
-	allowSides = true,
 	hasIndicator = true,
 }: Props ) {
 	const values = {
 		...DEFAULT_VALUES,
 		...valuesProp,
 	};
 
-	const isMixed: boolean =
-		allowSides &&
-		! (
-			values.topLeft === values.topRight &&
-			values.topLeft === values.bottomRight &&
-			values.topLeft === values.bottomLeft
-		);
+	const isMixed: boolean = ! (
+		values.topLeft === values.topRight &&
+		values.topLeft === values.bottomRight &&
+		values.topLeft === values.bottomLeft
+	);
 
 	const borderRadiusUnits = useCustomUnits( { availableUnits: BORDER_RADIUS_UNITS } );
 

diff --git a/src/controls/border-spacing-control.tsx b/src/controls/border-spacing-control.tsx
@@ -31,7 +31,6 @@ type Props = {
 	help?: string;
 	onChange: ( event: any ) => void;
 	values: typeof DEFAULT_VALUES;
-	allowSides?: boolean;
 	hasIndicator?: boolean;
 };
 
@@ -44,15 +43,14 @@ export default function BorderSpacingControl( {
 	help,
 	onChange,
 	values: valuesProp,
-	allowSides = true,
 	hasIndicator = true,
 }: Props ) {
 	const values = {
 		...DEFAULT_VALUES,
 		...valuesProp,
 	};
 
-	const isMixed: boolean = allowSides && ! ( values.horizontal === values.vertical );
+	const isMixed: boolean = ! ( values.horizontal === values.vertical );
 
 	const borderSpacingUnits = useCustomUnits( { availableUnits: BORDER_SPACING_UNITS } );
 
@@ -125,7 +123,7 @@ export default function BorderSpacingControl( {
 				</div>
 				<div className="ftb-border-spacing-control__controls">
 					<div className="ftb-border-spacing-control__controls-inner">
-						{ ( isLinked || ! allowSides ) && (
+						{ isLinked && (
 							<div className="ftb-border-spacing-control__controls-row">
 								{ hasIndicator && <DirectionIndicatorControl /> }
 								<UnitControl
@@ -139,7 +137,6 @@ export default function BorderSpacingControl( {
 							</div>
 						) }
 						{ ! isLinked &&
-							allowSides &&
 							DIRECTION_CONTROLS.map( ( item, index ) => (
 								<div className="ftb-border-spacing-control__controls-row" key={ index }>
 									{ hasIndicator && <DirectionIndicatorControl directions={ [ item.value ] } /> }
@@ -154,15 +151,13 @@ export default function BorderSpacingControl( {
 								</div>
 							) ) }
 					</div>
-					{ allowSides && (
-						<Button
-							className="ftb-border-spacing-control__header-linked-button"
-							label={ linkedLabel }
-							icon={ isLinked ? link : linkOff }
-							onClick={ toggleLinked }
-							size="small"
-						/>
-					) }
+					<Button
+						className="ftb-border-spacing-control__header-linked-button"
+						label={ linkedLabel }
+						icon={ isLinked ? link : linkOff }
+						onClick={ toggleLinked }
+						size="small"
+					/>
 				</div>
 			</div>
 		</BaseControl>

diff --git a/src/controls/padding-control.tsx b/src/controls/padding-control.tsx
@@ -43,7 +43,6 @@ type Props = {
 		bottom?: Property.PaddingBottom;
 		left?: Property.PaddingLeft;
 	};
-	allowSides?: boolean;
 	hasIndicator?: boolean;
 };
 
@@ -55,14 +54,15 @@ export default function PaddingControl( {
 	help,
 	onChange,
 	values: valuesProp,
-	allowSides = true,
 	hasIndicator = true,
 }: Props ) {
 	const values = { ...DEFAULT_VALUES, ...valuesProp };
 
-	const isMixed: boolean =
-		allowSides &&
-		! ( values.top === values.right && values.top === values.bottom && values.top === values.left );
+	const isMixed: boolean = ! (
+		values.top === values.right &&
+		values.top === values.bottom &&
+		values.top === values.left
+	);
 
 	const paddingUnits = useCustomUnits( { availableUnits: PADDING_UNITS } );
 
@@ -121,7 +121,7 @@ export default function PaddingControl( {
 					{ hasIndicator && (
 						<SideIndicatorControl sides={ side === undefined ? undefined : [ side ] } />
 					) }
-					{ ( isLinked || ! allowSides ) && (
+					{ isLinked && (
 						<UnitControl
 							placeholder={ allInputPlaceholder }
 							aria-label={ __( 'All', 'flexible-table-block' ) }
@@ -131,17 +131,15 @@ export default function PaddingControl( {
 							size="__unstable-large"
 						/>
 					) }
-					{ allowSides && (
-						<Button
-							className="ftb-padding-control__header-linked-button"
-							label={ linkedLabel }
-							onClick={ toggleLinked }
-							icon={ isLinked ? link : linkOff }
-							size="small"
-						/>
-					) }
+					<Button
+						className="ftb-padding-control__header-linked-button"
+						label={ linkedLabel }
+						onClick={ toggleLinked }
+						icon={ isLinked ? link : linkOff }
+						size="small"
+					/>
 				</div>
-				{ ! isLinked && allowSides && (
+				{ ! isLinked && (
 					<div className="ftb-padding-control__input-controls">
 						{ SIDE_CONTROLS.map( ( item ) => (
 							<UnitControl