Update to Vite ESM Build: Resolving CJS Node API Deprecation #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymmis
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Changes looking great and I also see that the test cases passed, fantastic!
I've written two small comments, and if I can ask, I would appreciate if you also did the same in the base package: got rid of ts-node which is used for tests and use tsx instead. That would maybe speed up the tests a little bit.
szymmis
approved these changes
Nov 26, 2023
|
Okay, tests are passing and everything seems to be working. I'll merge then. 🎉 |
|
Thank you! Please let me know if there is anything else I can do. |
|
The only thing left to do for now is to look at the problem described in #92. As always, if you want to take a look at it, I'd be happy to help you! Either way, thank you for every contribution you did! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vitejs.dev/guide/troubleshooting