Support async html transformer function #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymmis
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Hi @peterlama, thanks a lot for sharing your work!
I can totally see the use case, so great idea to implement that. The only issue right now is that tests don't pass and I see why. You need to make sure to await getTransformedHTML also in the injectIndexMiddleware function here.
Besides that, everything look great! Waiting for the change and we can ship it! 🎉
peterlama
force-pushed
the
feature/async-transformer
branch
from
9c5a0c4 to
89caf9f
Compare
|
That looks great! The one last thing is to add note about new async feature of transform function to README, are you willing to do that also? |
Having an async function to transform the html allows for more complex transformations, such as inserting data fetched from a database
peterlama
force-pushed
the
feature/async-transformer
branch
from
89caf9f to
70b1338
Compare
|
How's that? |
|
That's perfect 🎉, thank you again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an async function to transform the html allows for more complex transformations, such as inserting data fetched from a database.
I made this change for my own use case, but thought I would open a PR in case it would be helpful for others.