Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Set map view to defined point(s) #358

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Conversation

batabana
Copy link
Collaborator

No description provided.

Copy link
Member

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both onDataAdd function do the same. Can we extract that, so we have no duplication here?

@batabana batabana force-pushed the add-fit-bounds-functionality branch from 83c2aeb to 73c178c Compare October 14, 2022 15:34
@batabana batabana force-pushed the add-fit-bounds-functionality branch from 73c178c to d5c69c0 Compare October 14, 2022 15:37
@codecov-commenter
Copy link

Codecov Report

Merging #358 (d5c69c0) into main (4600f30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files           3        3           
  Lines          15       15           
  Branches        5        5           
=======================================
  Hits           14       14           
  Misses          1        1           
Impacted Files Coverage Δ
src/lib/replaceLinksHelper.ts 75.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@0x46616c6b 0x46616c6b merged commit 4b7ab23 into main Oct 16, 2022
@0x46616c6b 0x46616c6b deleted the add-fit-bounds-functionality branch October 16, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants