Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support Grafana 10.4 #145

Merged
merged 1 commit into from
Apr 9, 2024
Merged

✨ Support Grafana 10.4 #145

merged 1 commit into from
Apr 9, 2024

Conversation

JosefWN
Copy link
Contributor

@JosefWN JosefWN commented Apr 8, 2024

Hi, it's been a couple of years since these dashboards received some love. Tried to bring them at least somewhat up to par with the latest versions of Jitsi/Prometheus/Grafana. Tested with jitsi-helm master (running stable-9364) and kube-prometheus-stack 58.0.0 (running Grafana 10.4).

Is it worth maintaining two almost identical charts? Could we just go with "Jitsi & System" perhaps?

Fixes:

  • Fix typo in panel name & legend "Audo/videochannels" -> "Audio/video channels"
  • Fix typo in panel name "Videostreams" -> "Video streams"
  • Consistent casing in panel names & panel groups
  • Add dashboard tag "jitsi" to both dashboards
  • Fix deprecation: This plugin uses a deprecated, legacy platform based on AngularJS and will stop working in future releases of Grafana. https://grafana.com/docs/grafana/latest/developers/angular_deprecation/
  • Add missing "Videobridge stress level" to "Jitsi" chart (aligning with "Jitsi Meet & System")

Possible issues remaining:

  • With 3 people in a room, two with webcams on, I get "0 videostreams" consistently, is this intended? Is the metric broken?
  • "CPU busy", "Used RAM memory" and "Transfered data volume" are all "No data", perhaps I'm missing something?

@JosefWN JosefWN requested a review from 0x46616c6b as a code owner April 8, 2024 12:35
@0x46616c6b
Copy link
Member

Thank you for the contribution! I will try to review your changes as soon as possible and provide feedback.

Copy link
Member

@0x46616c6b 0x46616c6b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The dashboard "jitsi-meet-system" contains metrics from node-exporter. So, this only makes sense if you also have these exporter metrics available.

@0x46616c6b 0x46616c6b merged commit 7fe9812 into systemli:main Apr 9, 2024
3 of 4 checks passed
@0x46616c6b
Copy link
Member

Both Dashboards are updated at grafana.com/dashboards

@JosefWN
Copy link
Contributor Author

JosefWN commented Apr 9, 2024

@0x46616c6b Yes, I have the node exporter up and running, but the instance in the dropdown in the dashboard, which is obtained from the metric jitsi_conferences's instance label, corresponds to the Kubernetes-internal JVB pod IP, whereas the instance label on the metric node_cpu_seconds_total for example, is referring to the node IP.

I suspect it could be the JVB_WS_SERVER_ID which is determining the value of the exported metric label, which by default is set to the JVB pod's IP using, for example, jitsi-helm. I suppose this touches a bit on #116 as well, although I currently only have one videobridge.

@0x46616c6b 0x46616c6b changed the title Support Grafana 10.4 ✨ Support Grafana 10.4 May 24, 2024
@0x46616c6b 0x46616c6b added the enhancement New feature or request label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants