Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restart php-fpm if present #55

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Restart php-fpm if present #55

merged 3 commits into from
Aug 14, 2024

Conversation

t2d
Copy link
Contributor

@t2d t2d commented Aug 9, 2024 •
edited
Loading

  • Detect services automatically
  • Restart apache2 and php-fpm if they are present

@t2d t2d requested review from nevart and y3n4 August 9, 2024 19:31
doobry-systemli
doobry-systemli requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@doobry-systemli doobry-systemli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for tackling this. Also great to get rid of roundcube_apache. I have one comment though.

handlers/main.yml Outdated Show resolved Hide resolved
doobry-systemli
doobry-systemli approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@doobry-systemli doobry-systemli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like ❤️ I didn't know about the listen option in handlers so far, but it's a nice and clean solution.

nevart
nevart approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@nevart nevart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nevart nevart added the enhancement New feature or request label Aug 14, 2024
@t2d t2d merged commit 5e35220 into main Aug 14, 2024
3 checks passed
@t2d t2d deleted the php-fpm branch August 14, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nevart nevart nevart approved these changes

@doobry-systemli doobry-systemli doobry-systemli approved these changes

@y3n4 y3n4 Awaiting requested review from y3n4

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t2d @doobry-systemli @nevart