Check if roundcube directory exists, Unarchive if it does not exist. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neidiom
force-pushed
the
Check-if-roundcube-directory-exists
branch
from
48f50af to
694038e
Compare
t2d
reviewed
Apr 17, 2023
tasks/main.yml
Outdated
| path: "{{ roundcube_user_home }}/roundcubemail-{{ roundcube_version }}" | ||
| register: "roundcube_directory" | ||
|
|
||
| - name: Set roundcube_directory_exists fact |
There was a problem hiding this comment.
Why is it necessary to register an extra fact? Shouldn't it be possible to just check roundcube_directory.stat.exists?
neidiom
force-pushed
the
Check-if-roundcube-directory-exists
branch
from
694038e to
4f476e1
Compare
|
@t2d please review. |
doobry-systemli
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow when testing this role I ended up without the roundcube dir but with the archive file present. I got this error
This PR fixes that.