Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for group #36

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Add support for group #36

merged 1 commit into from
Apr 16, 2023

Conversation

neidiom
Copy link
Contributor

@neidiom neidiom commented Apr 16, 2023

No description provided.

@neidiom neidiom force-pushed the add_support_for_group branch 2 times, most recently from 8433656 to 355876f Compare April 16, 2023 08:36
@neidiom neidiom force-pushed the add_support_for_group branch from 355876f to 42f28cd Compare April 16, 2023 08:44
@doobry-systemli
Copy link
Contributor

What's the purpose of this PR? To be able to set the group to www-data in order to give the webserver user access to the roundcube installation? Why not set roundcube_user to the webserver user instead?

@neidiom
Copy link
Contributor Author

neidiom commented Apr 16, 2023

I am installing it under a control panel therefore every website has it's own user and group.

@neidiom
Copy link
Contributor Author

neidiom commented Apr 16, 2023

Also php-fpm is by default run with the same user/group. Example

drwxr-x--- 13 web17     client1      4096 Jan 23 21:03 roundcubemail-1.6.1

grep 'user\|group' /etc/php/8.1/fpm/pool.d/web17.conf

user = web17
group = client1

@neidiom
Copy link
Contributor Author

neidiom commented Apr 16, 2023

If default settings are used nothing really changes. This PR just adds extra customizable options.

@t2d t2d merged commit a7e53ee into systemli:main Apr 16, 2023
@t2d
Copy link
Contributor

t2d commented Apr 16, 2023

Cool, looks useful for situations like yours.

@neidiom neidiom deleted the add_support_for_group branch April 16, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants