Fix restart apache handler - Restart Apache when in services #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
neidiom
force-pushed
the
fix_restart_apache_service
branch
from
d69ccb6 to
2a1d18c
Compare
doobry-systemli
requested changes
Apr 16, 2023
There was a problem hiding this comment.
Thanks for your contribution. We're not opposed to adding support for Nginx (or other webservers), but relying on service_facts is not the right approach in my opinion. The simplest solution would be to add a new role variable roundcube_apache which is set to True per default and can be changed to False if people don't use apache.
neidiom
force-pushed
the
fix_restart_apache_service
branch
from
2a1d18c to
8815d26
Compare
|
@doobry-systemli please review. |
doobry-systemli
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using NginX therefore this fixes my issue with non-existent Apache service.