Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to primary / replica, drop master / slave #52

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Migrate to primary / replica, drop master / slave #52

merged 1 commit into from
Nov 17, 2023

Conversation

nevart
Copy link
Contributor

@nevart nevart commented Nov 13, 2023

This fixes errors, if running with ansible 2.14, due to unsupported param getslave which was dropped.

Besides, this change also adjusts internal, private params and relies on primary, instead of master.

@nevart
Copy link
Contributor Author

nevart commented Nov 13, 2023 •
edited
Loading

SLAVE is still used within tasks/replication.yml:14 to configure privileges -- I wasn't sure what to replace it with as I had troubles navigating the MariaDB upstream docs. If anyone could shed some light on this I'm all ears.

@nevart
Copy link
Contributor Author

nevart commented Nov 13, 2023

I believe these are breaking changes, so that should probably land in 2.0.0?

@nevart
Copy link
Contributor Author

nevart commented Nov 13, 2023

I've tested these changes, via --check, on two hosts with replication enabled -- no changes were reported.

@nevart nevart self-assigned this Nov 13, 2023
@nevart
Copy link
Contributor Author

nevart commented Nov 14, 2023

SLAVE is still used within tasks/replication.yml:14 to configure privileges -- I wasn't sure what to replace it with as I had troubles navigating the MariaDB upstream docs. If anyone could shed some light on this I'm all ears.

@doobry-systemli Thanks for your review -- any idea wrt the above?

@doobry-systemli
Copy link
Contributor

@doobry-systemli Thanks for your review -- any idea wrt the above?

According to https://mariadb.com/kb/en/grant/#replication-replica REPLICATION REPLICA is a synonym for REPLICATION SLAVE starting with MariaDB 10.5.1.

@nevart @doobry-systemli
Migrate to primary / replica, drop master / slave
78636ba 
This fixes errors, if running with ansible 2.14, due to unsupported
param 'getslave', which was dropped.

Besides, this change also adjusts internal, private params and relies on
'primary', instead of 'master'.
@doobry-systemli doobry-systemli added the bug Something isn't working label Nov 17, 2023
@doobry-systemli
Copy link
Contributor

According to https://mariadb.com/kb/en/grant/#replication-replica REPLICATION REPLICA is a synonym for REPLICATION SLAVE starting with MariaDB 10.5.1.

Pushed this change now.

@doobry-systemli doobry-systemli merged commit 50b3c54 into main Nov 17, 2023
4 checks passed
@doobry-systemli doobry-systemli deleted the migrate-to-primary-replica branch November 17, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doobry-systemli doobry-systemli doobry-systemli approved these changes

Assignees

@nevart nevart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevart @doobry-systemli