-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidenav): update sidenav to typescript #917
Conversation
d18b4e2
to
6a3d71e
Compare
@hasparus Mind having a look please? |
9646abe
to
79484f6
Compare
79484f6
to
4d07a51
Compare
7099a1f
to
a2b78b5
Compare
a2b78b5
to
e3440bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
I'll test it and merge it soon.
Okay, I'm merging it right now.
<div
{...props}
ref={ref}
sx={{
position: ['fixed', 'sticky'],
top: 0,
left: 0,
bottom: [0, 'auto'],
zIndex: 1,
minWidth: 0,
width: 256,
maxHeight: ['100vh', 'none'],
overflowX: 'visible',
overflowY: 'auto',
transition: 'transform .2s ease-out',
transform: [open ? 'translateX(0)' : 'translate(-100%)', 'none'],
bg: ['background', 'transparent'],
...{ WebkitOverflowScrolling: 'touch' },
// WebkitOverflowScrolling is not supported in our types
}}
/> I just wanted to mention the workaround for posterity. For this particular case, I think I have a fix. |
6f6d347
to
ad15f07
Compare
Convert to typescript:
Relates to: #668