Add accentColor to css properties #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a797834:
|
lachlanjc
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR adds
accentColorto the list of theme-supported properties under thecolorspace. This way, the chose accent-color can be set using a color from the theme.The Problem
Today, setting the accent color to a key in the theme does not pull the corresponding value from the theme. Our team ran into this issue recently trying to set the accent color for a
checkboxelement.i.e.
accentColor: 'primary'->accentColor: 'primary'Expected Behavior
accentColor: 'primary'->accentColor: 'tomato'('tomato' would be the value in the theme in this example)Version
Published prerelease version:
v0.16.2-develop.2Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Jeff Bell (@jhbell)
❤️ Paweł Kowalewski (@pawkow)
🐛 Bug Fix
🏠 Internal
Authors: 2