Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): Update IconButton type definition to include size prop #2121

Merged

Conversation

rtturner
Copy link
Contributor

@rtturner rtturner commented Feb 7, 2022

IconButton has a size attribute defined but it is not reflected in the IconButtonProps interface.

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/systemui/theme-ui/FVdMqgMTVJTgS1i7f3vUhMT1zEBo
✅ Preview: https://theme-ui-git-fork-rtturner-fix-icon-button-type-1248e2-systemui.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4924c36:

Sandbox Source
next-theme-ui-example Configuration
gatsby-plugin-theme-ui-example Configuration

@hasparus
Copy link
Member

hasparus commented Feb 8, 2022

Thanks for the PR @rtturner!

Copy link
Member

@lachlanjc lachlanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@hasparus
Copy link
Member

🚀 PR was released in v0.14.0 🚀

@hasparus hasparus added the released This issue/pull request has been released. label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants