feat(color-modes): Add configuration option for printing color mode #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the failing tests are unrelated to the changes & have been failing since at least #1249 :/ |
|
Brilliant |
Yup, it seems we broke it while fixing the docs build, I'll handle it. |
hasparus
reviewed
Jan 18, 2021
| printColorModeName === initialColorModeName | ||
| ? colors | ||
| : modes[printColorModeName] | ||
| styles['@media (print)'] = objectToVars('colors', mode) |
There was a problem hiding this comment.
@lachlanjc shouldn't this be @media print? (without parens) I just noticed it doesn't work on Brave/Linux.
There was a problem hiding this comment.
Yep, you're totally right. I always forget about that since it's the only media query I use without parentheses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1144, adding a configuration option
printColorModeNamefor setting a color mode to be used in@media (print)(so users don’t print out in dark mode). By using the media query & custom properties, there’s no client-side JavaScript event listeners, so it should work even on a static-exported site.PR includes updated TypeScript type, documentation, & two tests.