Fixing types for props with ref

[mzabriskie]

The props for components are incorrectly typed in most cases. Since all components use forwardRef they should be using ComponentPropsWithRef (see note in @types/react).

Without this change type errors are given when passing a ref to a component. A case where this shows up is in Storybook:

// This will give a type error because `args` will include `ref`, but it is incompatible with `LabelProps.ref`
const Template: Story<LabelProps> = (args) => <Label {...args} />

// Workaround
const Template: Story<LabelProps> = ({ ref, ...args }) => <Label {...args} />

With this change type errors are resolved and the above workaround is no longer needed.

Fixes #881

[hasparus]

Thanks for the PR, @mzabriskie!

[mzabriskie]

@hasparus my pleasure. I am wondering about how @types/theme-ui__components comes into the picture. Since you have moved the type definitions to @theme-ui/components I believe the @types package ought to be removed. Otherwise, it is also incorrectly defined and would need a PR as well.

[hasparus]

That's correct. Fixes to components types should be ported to DefinitelyTyped to update @types/theme-ui__components for Theme UI 0.3 users. We can remove @types/theme-ui__components (i.e. publish new version which is a stub) after stable 0.4 release.

[hasparus]

I just tested it locally. Let's release it fast.

[hasparus]

@mzabriskie Do you want to PR DefinitelyTyped, or should I take care of it?