-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Friendlier TypeScript errors. #1002
Merged
+1,191
−946
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
7870a45
Add label prop to ThemeUIStyleObject
hasparus 0647c3c
Change core/test/index extension to tsx
hasparus 8e65bd9
Add overloads to merge.all
hasparus 41e2e63
Fix type errors in core/test/index
hasparus 671c4e7
Bump deps to use optional chaining in tests
hasparus 089b302
Use optional chaining in @theme-ui/css tests
hasparus 103d6b9
Report friendlier TypeScript errors in style objects
hasparus ea8346f
Make @theme-ui/css strict TypeScript
hasparus 8cfdfad
Test that ThemeUIStyleObject errors are not confusing anymore
hasparus bebb666
Update reexport name
hasparus 120192f
Import * as React in @theme-ui/core
hasparus 8722aab
Remove unused export
hasparus 30c522f
Make test/errors.ts expectSnippet strict
hasparus 89253aa
Export ColorModesScale
hasparus 8cfd2ef
Draft TypeScript chapter for the docs
hasparus 00ff818
Add numeric index signature to ObjectOrArray
hasparus a5ad143
Remove unused imports
hasparus 9033499
Add exact theme reexport example
hasparus 3836ea1
Reference other pages in docs and add a sentence
hasparus 92b13ec
Merge remote-tracking branch 'origin/master' into better-ts-errors
hasparus 26017d4
Rename ObjectOrArray to Scale
hasparus b4a883f
Steal jxnblk's paragraph
hasparus 0756514
Update typescript.mdx
hasparus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unused export
- v0.17.2-develop.0
- v0.17.1
- v0.17.1-develop.0
- v0.17.0
- v0.17.0-develop.1
- v0.17.0-develop.0
- v0.16.2
- v0.16.2-develop.5
- v0.16.2-develop.4
- v0.16.2-develop.2
- v0.16.2-develop.1
- v0.16.2-develop.0
- v0.16.1
- v0.16.1-develop.0
- v0.16.0
- v0.16.0-develop.4
- v0.16.0-develop.3
- v0.16.0-develop.2
- v0.16.0-develop.1
- v0.16.0-develop.0
- v0.15.9-develop.0
- v0.15.8
- v0.15.8-develop.1
- v0.15.8-develop.0
- v0.15.7
- v0.15.6
- v0.15.6-develop.1
- v0.15.6-develop.0
- v0.15.5
- v0.15.5-develop.2
- v0.15.5-develop.1
- v0.15.5-develop.0
- v0.15.4
- v0.15.4-develop.0
- v0.15.3
- v0.15.3-develop.0
- v0.15.2
- v0.15.2-develop.0
- v0.15.1
- v0.15.0
- v0.15.0-develop.29
- v0.15.0-develop.28
- v0.15.0-develop.27
- v0.15.0-develop.26
- v0.15.0-develop.25
- v0.15.0-develop.24
- v0.15.0-develop.23
- v0.15.0-develop.22
- v0.15.0-develop.21
- v0.15.0-develop.20
- v0.15.0-develop.19
- v0.15.0-develop.18
- v0.15.0-develop.17
- v0.15.0-develop.16
- v0.15.0-develop.15
- v0.15.0-develop.14
- v0.15.0-develop.13
- v0.15.0-develop.12
- v0.15.0-develop.11
- v0.15.0-develop.10
- v0.15.0-develop.9
- v0.15.0-develop.8
- v0.15.0-develop.7
- v0.15.0-develop.6
- v0.15.0-develop.5
- v0.15.0-develop.4
- v0.15.0-develop.3
- v0.15.0-develop.2
- v0.15.0-develop.1
- v0.15.0-develop.0
- v0.14.7
- v0.14.6
- v0.14.5
- v0.14.5-develop.0
- v0.14.4
- v0.14.4-develop.1
- v0.14.4-develop.0
- v0.14.3
- v0.14.3-develop.1
- v0.14.3-develop.0
- v0.14.2
- v0.14.2-develop.2
- v0.14.2-develop.1
- v0.14.2-develop.0
- v0.14.1
- v0.14.1-develop.0
- v0.14.0
- v0.14.0-develop.25
- v0.14.0-develop.24
- v0.14.0-develop.23
- v0.14.0-develop.22
- v0.14.0-develop.21
- v0.14.0-develop.20
- v0.14.0-develop.19
- v0.14.0-develop.18
- v0.14.0-develop.17
- v0.14.0-develop.16
- v0.14.0-develop.15
- v0.14.0-develop.14
- v0.14.0-develop.13
- v0.14.0-develop.12
- v0.14.0-develop.11
- v0.14.0-develop.10
- v0.14.0-develop.9
- v0.14.0-develop.8
- v0.14.0-develop.7
- v0.14.0-develop.6
- v0.14.0-develop.5
- v0.14.0-develop.4
- v0.14.0-develop.3
- v0.14.0-develop.2
- v0.14.0-develop.1
- v0.14.0-develop.0
- v0.13.1
- v0.13.1-develop.9
- v0.13.1-develop.8
- v0.13.1-develop.7
- v0.13.1-develop.6
- v0.13.1-develop.5
- v0.13.1-develop.4
- v0.13.1-develop.3
- v0.13.1-develop.2
- v0.13.1-develop.1
- v0.13.1-develop.0
- v0.13.0
- v0.13.0-develop.1
- v0.13.0-develop.0
- v0.12.2-develop.8
- v0.12.2-develop.7
- v0.12.2-develop.6
- v0.12.2-develop.5
- v0.12.2-develop.4
- v0.12.2-develop.3
- v0.12.2-develop.2
- v0.12.2-develop.1
- v0.12.2-develop.0
- v0.12.1
- v0.12.1-develop.6
- v0.12.1-develop.5
- v0.12.1-develop.4
- v0.12.1-develop.3
- v0.12.1-develop.2
- v0.12.1-develop.1
- v0.12.1-develop.0
- v0.12.0
- v0.12.0-develop.0
- v0.11.4-develop.16
- v0.11.4-develop.15
- v0.11.4-develop.14
- v0.11.4-develop.13
- v0.11.4-develop.12
- v0.11.4-develop.11
- v0.11.4-develop.10
- v0.11.4-develop.9
- v0.11.4-develop.8
- v0.11.4-develop.7
- v0.11.4-develop.6
- v0.11.4-develop.5
- v0.11.4-develop.4
- v0.11.4-develop.3
- v0.11.4-develop.2
- v0.11.4-develop.1
- v0.11.4-develop.0
- v0.11.3
- v0.11.3-develop.5
- v0.11.3-develop.4
- v0.11.3-develop.3
- v0.11.3-develop.2
- v0.11.3-develop.1
- v0.11.3-develop.0
- v0.11.2
- v0.11.2-develop.4
- v0.11.2-develop.3
- v0.11.2-develop.2
- v0.11.2-develop.1
- v0.11.2-develop.0
- v0.11.1
- v0.11.0
- v0.11.0-develop.2
- v0.11.0-develop.1
- v0.11.0-develop.0
- v0.10.1-develop.0
- v0.10.0
- v0.9.2-develop.6
- v0.9.2-develop.5
- v0.9.2-develop.4
- v0.9.2-develop.3
- v0.9.2-develop.1
- v0.9.2-develop.0
- v0.9.1
- v0.9.1-develop.0
- v0.9.0
- v0.9.0-develop.1
- v0.9.0-develop.0
- v0.8.5-develop.0
- v0.8.4
- v0.8.3
- v0.8.3-develop.0
- v0.8.2
- v0.8.2-develop.2
- v0.8.2-develop.1
- v0.8.2-develop.0
- v0.8.1
- v0.8.0
- v0.8.0-develop.0
- v0.7.5
- v0.7.5-develop.0
- v0.7.4
- v0.7.4-develop.2
- v0.7.4-develop.1
- v0.7.4-develop.0
- v0.7.3
- v0.7.3-develop.0
- v0.7.2
- v0.7.1
- v0.7.1-develop.0
- v0.7.0
- v0.7.0-develop.0
- v0.6.2
- v0.6.1
- v0.6.0
- v0.6.0-alpha.8
- v0.6.0-alpha.7
- v0.6.0-alpha.6
- v0.6.0-alpha.5
- v0.6.0-alpha.4
- v0.6.0-alpha.3
- v0.6.0-alpha.2
- v0.6.0-alpha.1
- v0.6.0-alpha.0
- v0.5.0-alpha.2
- v0.5.0-alpha.1
- v0.5.0-alpha.0
- v0.4.0-rc.14
- v0.4.0-rc.13
- v0.4.0-rc.12
- v0.4.0-rc.11
- v0.4.0-rc.10
- v0.4.0-rc.9
- v0.4.0-rc.8
- v0.4.0-rc.7
- v0.4.0-rc.6
- v0.4.0-rc.5
- v0.4.0-rc.3
- v0.4.0-rc.2
- v0.0.0
- ls
commit 8722aab62b1518de39175b3a57c4ca82a499c9b6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"use" is already a loaded word in React world. Tell me what you think about the rename.
Another name I considered is
ComputedStyle
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emotion calls it
FunctionInterpolation
, but since we don't do CSS syntax in tagged template literals here, I'm not sure it would makes sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that
UseThemeFunction
is not great. I'm good with bothThemeDerivedStyles
andComputedStyles
(plural?).