Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give logo image a white BG on README #2417

Closed
ghost opened this issue Apr 15, 2023 · 2 comments
Closed

Give logo image a white BG on README #2417

ghost opened this issue Apr 15, 2023 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 15, 2023 •
edited by ghost
Loading

Is your feature request related to a problem? Please describe.
On the README.md file, the logo that is displayed is impossible to see on Github's Default Dark Theme. Screenshot provided in context section.

Describe the solution you'd like
Give the logo image a white background.

Describe alternatives you've considered
Just switching to light mode- but can't really do that just for one repository every time you want to look at it...

Additional context
Screen Shot 2023-04-15 at 10 44 21 AM

In the screenshot it looks easier to see, however in real life on a real computer, it is hard to see the logo.
@sammarxz sammarxz mentioned this issue Jul 19, 2023
Merged
@sammarxz
Copy link
Contributor

PR: #2446

hasparus added a commit that referenced this issue Aug 1, 2023
@hasparus
Merge pull request #2446 from sammarxz/(hotfix)-issue-#2417
8318601 
(hotfix) issue #2417
@ghost
Copy link
Author

ghost commented Aug 5, 2023

FIxed with #2446

@ghost ghost closed this as completed Aug 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sammarxz