-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid gap property not reading theme space values #1857
Comments
Hey @sergeylukin, do you maybe have a reproduction repo or CodeSandbox? It seems to work in the docs. What versions of Theme UI and Emotion do you have? Are you maybe using Theme UI inside of Storybook? |
Fwiw, this works fine for me! So more likely a setup issue. |
The problem might be caused by context version mismatch (and serve as another reason for us to move Emotion to peerDeps), so I'd look for the cause in package.json. |
Will export my setup to codesandox during today-tomorrow and provide a proof or will prove myself wrong, thank you @lachlanjc @hasparus ! |
@hasparus you're right, I found 2 versions of ...because I've used @emotion/react internals in my project. What's the solution as long as I do want to use @emotion/react in my project? Is it just aligning the version of |
Check this out! #1531 (comment) There's some other issues with that label with more conversations as well. |
@sergeylukin, you can either use yarn resolutions to enforce the new Emotion version on Theme UI or downgrade yours (does 11.4 have anything new you're using)? We're definitely moving Emotion to peerDeps in next bigger release, @lachlanjc :/ |
@hasparus makes sense, thank you! 🙏 |
Describe the bug
Hi,
<Grid />
gap
property doesn't respect spaces from connected theme whilesx
does.To Reproduce
Steps to reproduce the behavior:
Expected behavior
<Grid gap={2} />
resulting in grid with gap of 4pxThe text was updated successfully, but these errors were encountered: