-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark Theme UI as written in TypeScript in DefinitelyTyped #1582
Comments
Even theme-ui v0.4 was partially converted, not sure if it's worth going that deep into the versions though? 🤷♂️
Do we already know of any other package referencing theme-ui types? |
It seems we're clear on this front.
|
I have never removed a package from DT, do we need specific permissions to run the Otherwise I can submit a PR perhaps |
I don't think so, but I'm not 100% sure. |
I'll figure it out :) |
Perhaps theme-ui__components 🤔? Or should we also remove that one now? (is it too early?) |
theme-ui provides its own types as of v0.6.0 (system-ui/theme-ui#1582))
@theme-ui/components provides its own types as of v0.6.0 (system-ui/theme-ui#1582))
We can defo treat it like written in TypeScript — we maintain these types and some day we're gonna merge them with the implementation. |
Yeah, I had the same thing in mind :) |
…needed) (#52551) * feat(theme-ui): remove theme-ui package theme-ui provides its own types as of v0.6.0 (system-ui/theme-ui#1582)) * feat(theme-ui__components): remove theme-ui__components package @theme-ui/components provides its own types as of v0.6.0 (system-ui/theme-ui#1582))
Thanks for this @flo-sch! |
Theme UI 0.3 had its types in DefinitelyTyped. Theme UI 0.6 is written in TypeScript and bundles its types.
We need to follow the "Removing a package" instruction to mark Theme UI as rewritten to TS which will cause a publish of stub definitions with a warning telling people they don't need @types/theme-ui when they install it.
The text was updated successfully, but these errors were encountered: