Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APP_CONFIG flag to configure dialog behaviour for default #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jferrer1W
Copy link
Contributor

PR Details

A new configuration object for the default behavior of dialogs is added, along with a new flag to determine whether dialogs are draggable by default or not.

Description

In some projects, we don’t want dialogs to be draggable by default, and it’s costly to update every systelab-header instance to set the withDrag flag to false, especially since this flag is true by default. To maintain backward compatibility for any project that expects dialogs to be draggable by default, we’ve added a new configuration object to APP_CONFIG, similar to the ToastConfig, to define a default behavior for dialogs. This object includes the dialogsDraggableByDefault flag, which determines whether dialogs are draggable by default or not.

This behavior of allowing dialogs to be draggable by default causes a bug where, in full-size dialogs, the header can be dragged independently.

Related Issue

#953

Motivation and Context

This behavior of allowing dialogs to be draggable by default causes a bug where, in full-size dialogs, the header can be dragged independently.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@jferrer1W jferrer1W linked an issue Nov 20, 2024 that may be closed by this pull request
@jferrer1W jferrer1W requested review from fjaguado and carlosra85 and removed request for fjaguado November 20, 2024 17:17
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.68%. Comparing base (54be6c0) to head (bccb727).

Files with missing lines Patch % Lines
...ts/src/lib/modal/header/dialog-header.component.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   57.70%   57.68%   -0.02%     
==========================================
  Files         132      133       +1     
  Lines        3743     3746       +3     
  Branches      659      660       +1     
==========================================
+ Hits         2160     2161       +1     
  Misses       1473     1473              
- Partials      110      112       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is possible to drag the headers of full-size dialogs
2 participants