New APP_CONFIG flag to configure dialog behaviour for default #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
A new configuration object for the default behavior of dialogs is added, along with a new flag to determine whether dialogs are draggable by default or not.
Description
In some projects, we don’t want dialogs to be draggable by default, and it’s costly to update every systelab-header instance to set the withDrag flag to false, especially since this flag is true by default. To maintain backward compatibility for any project that expects dialogs to be draggable by default, we’ve added a new configuration object to APP_CONFIG, similar to the ToastConfig, to define a default behavior for dialogs. This object includes the dialogsDraggableByDefault flag, which determines whether dialogs are draggable by default or not.
This behavior of allowing dialogs to be draggable by default causes a bug where, in full-size dialogs, the header can be dragged independently.
Related Issue
#953
Motivation and Context
This behavior of allowing dialogs to be draggable by default causes a bug where, in full-size dialogs, the header can be dragged independently.
How Has This Been Tested
Types of changes
Checklist