Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Accordion Component #952

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

jferrer1W
Copy link
Contributor

PR Details

It contains the code to new Accordion component

Description

We have created a new Accordion component.

Related Issue

#949

Motivation and Context

Add generic component that now was into modulab

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@jferrer1W jferrer1W force-pushed the 949/17.4.x/new-accordion-component branch from 4fc6c47 to 0519616 Compare November 15, 2024 16:17
@jferrer1W jferrer1W requested a review from carlosra85 November 15, 2024 16:17
@jferrer1W jferrer1W force-pushed the 949/17.4.x/new-accordion-component branch 2 times, most recently from 8037717 to 31615d0 Compare November 18, 2024 07:47
add test coveraging

fix name of scss class removing mlab prefix

Add readme of accordion component

replace prefix for suffix in preferencesName
@jferrer1W jferrer1W force-pushed the 949/17.4.x/new-accordion-component branch from 31615d0 to 049f8f3 Compare November 20, 2024 09:17
@vinyulis vinyulis self-requested a review November 20, 2024 09:29
@jferrer1W jferrer1W merged commit 3f97fa9 into 17.4.x Nov 20, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants