Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define GOVERNANCE.md #529

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Define GOVERNANCE.md #529

wants to merge 11 commits into from

Conversation

alfonsserra
Copy link
Contributor

@alfonsserra alfonsserra commented Nov 24, 2021

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly (README.md for each UI component)
  • I have added tests to cover my changes (at least 1 spec for each UI component with the same coverage as the master branch)
  • All new and existing tests passed
  • A new branch needs to be created from master to evolve previous versions
  • Increase version in package.json following Semantic Versioning
  • All UI components must be added into the showcase (at least 1 component with the default settings)
  • Add the issue into the right project with the proper status (In progress)

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #529 (f404ad3) into master (b9006ef) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #529      +/-   ##
==========================================
+ Coverage   50.90%   51.02%   +0.12%     
==========================================
  Files         120      120              
  Lines        3220     3257      +37     
  Branches      553      567      +14     
==========================================
+ Hits         1639     1662      +23     
- Misses       1357     1372      +15     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
...ents/src/lib/listbox/abstract-listbox.component.ts 45.65% <0.00%> (+0.41%) ⬆️
...ts/src/lib/combobox/abstract-combobox.component.ts 52.94% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9006ef...f404ad3. Read the comment docs.

@alfonsserra alfonsserra marked this pull request as ready for review May 26, 2022 08:34
@alfonsserra alfonsserra changed the title Update and rename ROLES.md to GOVERNANCE.md Define GOVERNANCE.md May 26, 2022
Copy link
Contributor

@oGalceran1 oGalceran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

The GitHub team for Systelab libraries core collaborators is @systelab/anguler-team.
Collaborators have:

* Commit access to the [systelab/systelab-components][] repository
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You refer to systelab-components.
Do you want to refer it or do you want a general document?

- Olga Puig
- Daniel Martinez
- Josep Vila
- Aritz Peñalver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this to remove Aritz

* Conduct guidelines
* Maintaining the list of collaborators

The current list of TSC members is:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The members should depend on the library, isn't it?

Copy link
Contributor

@vinyulis vinyulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add Carlos Rodríguez to TSC

Copy link
Contributor

@oGalceran1 oGalceran1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alfons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants