Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce build warnings to minimum #1

Closed
wants to merge 1 commit into from
Closed

Reduce build warnings to minimum #1

wants to merge 1 commit into from

Conversation

fbiville
Copy link

@fbiville fbiville commented Aug 4, 2018

There remains only one which I do not fully understand.
It is relevant to this compiler bug: scala/bug#4440

The rest has been fixed, by:

  • fixing build encoding
  • explicitly setting scalac flags
  • specifying missing artefact versions
  • rewriting exception assertions
  • replacing deprecated data structures

@fbiville
Copy link
Author

fbiville commented Aug 4, 2018

Actually, I just realized I should have done this work on new-semantic-analysis 🤦‍♂️
Feel free to discard this pull request if it doesn't bring much value, this was a way for me to get my feet wet.

nicokosi
nicokosi reviewed Aug 4, 2018
View reviewed changes
rewriting/src/test/scala/org/opencypher/v9_0/rewriting/NormalizeWithClausesTest.scala Outdated
@@ -584,7 +584,7 @@ class NormalizeWithClausesTest extends CypherFunSuite with RewriteTest with AstC
}

test("match (n) with n as n order by max(n) return n") {
evaluating { rewriting("match (n) with n as n order by max(n) return n") } should produce[SyntaxException]
an [SyntaxException] should be thrownBy { rewriting("match (n) with n as n order by max(n) return n") }
Copy link

@nicokosi nicokosi Aug 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a [SyntaxException], maybe? 😉
I don't know if the test library imposes "an" or not. 😇

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, merci Nico

@fbiville
Copy link
Author

fbiville commented Aug 4, 2018 •
edited
Loading

Only warning left:

[WARNING] front-end/util/src/main/scala/org/opencypher/v9_0/util/helpers/TreeZipper.scala:41: warning: The outer reference in this type test cannot be checked at run time.
[WARNING]   final case class Location(elem: E, context: Context) {
[WARNING]                    ^
[WARNING] one warning found

@fbiville
Reduce build warnings to minimum
5a631be 
There remains only one which I do not fully understand.
It is relevant to this compiler bug: scala/bug#4440

The rest has been fixed, by:

 - fixing build encoding
 - explicitly setting scalac flags
 - specifying missing artefact versions
 - rewriting exception assertions
 - replacing deprecated data structures
@fbiville fbiville closed this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicokosi nicokosi nicokosi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbiville @nicokosi