Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rv->compressed for instruction ecall and ebreak #96

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

qwe661234
Copy link
Collaborator

The exception handler is invoked by the instructions ecall and ebreak, thus we must set rv->compressed for these instructions.

@jserv jserv requested a review from Risheng1128 December 17, 2022 11:41
Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, check your git commit message.

@qwe661234 qwe661234 force-pushed the patch_emulate branch 2 times, most recently from b2145e7 to 990fd38 Compare December 17, 2022 15:47
@qwe661234 qwe661234 changed the title Set rv->compressed in ecall and ebreak Set rv->compressed for instruction ecall and ebreak Dec 17, 2022
The exception handler is invoked by the instructions ecall and ebreak,
thus we must set rv->compressed for these instructions.
@jserv jserv merged commit c762de5 into sysprog21:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants