Fix duplicate item detection issue #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the 'is_this_dup' from qtest.c's delete duplicate implementation. Previously, 'is_this_dup' was used to indicate if the current item in the old list was a duplicate of the previous item, while 'is_next_dup' indicated if the current item was a duplicate of the next item. This led to comparisons always skipping when (is_next_dup || is_this_dup) was true, resulting in the item with duplicates not being compared with items in the new list. The 'is_next_dup' is retained for accurate comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the 'is_this_dup' from qtest.c's delete duplicate implementation.
Previously, 'is_this_dup' was used to indicate if the current item in the old list was a duplicate of the previous item, while 'is_next_dup' indicated if the current item was a duplicate of the next item.
This led to comparisons always skipping when (is_next_dup || is_this_dup) was true, resulting in the item with duplicates not being compared with items in the new list.
The 'is_next_dup' is retained for accurate comparison.