bugfix/python 3.10 not detected FIX #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS |
Kokan
reviewed
Jun 25, 2021
news/bugfix-3713.md
Outdated
| - using if-else instead of switch-case, because in the if statement can be put regex expression. | ||
| - using the configure "if-else", because there can put regex expression also. | ||
|
|
||
| issue: #3709 |
There was a problem hiding this comment.
This si going to be part of the news file (an example: https://github.com/syslog-ng/syslog-ng/releases/tag/syslog-ng-3.32.1), if you check out that the description are brief (specially in case of simple bugfix). This description is nice for the PR description, but too detailed for a news entry.
From user point of view the implementation details are not interesting (still they can uncover it as there is a reference to the original PR), I would rather include the fact that configure cannot accept python 3.10 version, and now it does.
gaborznagy
reviewed
Jun 25, 2021
Barkodcz
force-pushed
the
bugfix/3709_python_310_not_detected
branch
from
a2ad3ba
to
d62c58c
Compare
* configure can accept python x.xx * I try to use * or + like in regex, but in shell isn't compatible with that regex Signed-off-by: Balázs Barkó <[email protected]>
Barkodcz
force-pushed
the
bugfix/3709_python_310_not_detected
branch
from
d62c58c
to
572a2cb
Compare
Kokan
previously approved these changes
Jun 28, 2021
|
Build SUCCESS |
Signed-off-by: Balázs Barkó <[email protected]>
Barkodcz
force-pushed
the
bugfix/3709_python_310_not_detected
branch
from
572a2cb
to
34252ce
Compare
alltilla
approved these changes
Jun 28, 2021
gaborznagy
approved these changes
Jun 28, 2021
|
Build SUCCESS |
|
Thanks! Tested by compiling a recent git master snapshot on Fedora Rawhide, and it works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was the new python 3.10 isn't compatible with previous "python finding script", because it check is only 1 digit or "." and I added a new condition to check ".".
This bug can be easily caused. Only need a python 3.10 version and run the configure with this flag: "--with-python=3.10" it will not find the 3.10, but with the bugfix it will found.
Other possible solution:
issue: #3709