Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java/gradle: replace deprecated options in gradle 7 #3645

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

Kokan
Copy link
Collaborator

@Kokan Kokan commented Apr 15, 2021

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@gaborznagy gaborznagy self-requested a review April 15, 2021 11:46
lbudai
lbudai previously approved these changes Apr 15, 2021
@Kokan Kokan marked this pull request as ready for review April 16, 2021 04:59
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump GRADLE_MIN_VERSION="2.2" with this change?

implementation seems to be a >v3 keyword.
https://docs.gradle.org/3.4/release-notes.html

@Kokan
Copy link
Collaborator Author

Kokan commented Apr 16, 2021

Sure, bumped to 3.4 as min version.

Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@gaborznagy gaborznagy merged commit 5bcd956 into syslog-ng:master Apr 16, 2021
Kokan added a commit to Kokan/syslog-ng that referenced this pull request Apr 27, 2021
Kokan added a commit to Kokan/syslog-ng that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants