Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example-msg-generator: support fast message generation #3245

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

vatsal-encs
Copy link
Contributor

fixes #3241

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

2 similar comments
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@Kokan
Copy link
Collaborator

Kokan commented Apr 17, 2020

@kira-syslogng ok to test

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@furiel
Copy link
Collaborator

furiel commented Apr 17, 2020

@vatsal-encs I mentioned a reference to an e2e test in the original issue. Could you update that too? From now freq="0" should work. It would implicitely test your code too.

@kira-syslogng
Copy link
Contributor

Build SUCCESS

news/feature-3245.md Outdated Show resolved Hide resolved
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@vatsal-encs vatsal-encs reopened this Apr 17, 2020
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@vatsal-encs vatsal-encs reopened this Apr 17, 2020
@kira-syslogng
Copy link
Contributor

Build SUCCESS

Copy link
Collaborator

@furiel furiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally, I was thinking that we could do this in a timerless fashion. Even with freq=0, every messages are generated with a timer in different loops of the event loop. Which feels unnecessary, and maybe slower than not having timers at all.

On the other hand I always forget example-msg-generator is a simple source, and not a threaded source. So quite some work would needed to achieve that. Improved management of free_to_send, and introducing log-fetch-limit, maybe others? Also, even with null-timers, this source is very fast, so I would not open the scope now.

Approve from my side.

@MrAnno MrAnno merged commit cb13b06 into syslog-ng:master Apr 20, 2020
@vatsal-encs vatsal-encs deleted the example-msg-generator branch April 20, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example-msg-generator: support fast message generation
5 participants