-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example-msg-generator: support fast message generation #3245
Conversation
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
2 similar comments
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
This user does not have permission to start the build. Can one of the admins verify this patch and start the build? |
@kira-syslogng ok to test |
Build SUCCESS |
4132132
to
a75bc6a
Compare
@vatsal-encs I mentioned a reference to an e2e test in the original issue. Could you update that too? From now |
Build SUCCESS |
Signed-off-by: Vatsal Sisodiya <[email protected]>
Signed-off-by: Vatsal Sisodiya <[email protected]>
a75bc6a
to
416205d
Compare
Build SUCCESS |
Build SUCCESS |
Build SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, I was thinking that we could do this in a timerless fashion. Even with freq=0
, every messages are generated with a timer in different loops of the event loop. Which feels unnecessary, and maybe slower than not having timers at all.
On the other hand I always forget example-msg-generator
is a simple source, and not a threaded source. So quite some work would needed to achieve that. Improved management of free_to_send
, and introducing log-fetch-limit
, maybe others? Also, even with null-timers, this source is very fast, so I would not open the scope now.
Approve from my side.
fixes #3241