Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite: added conditional set-tag rule #3190

Merged
merged 2 commits into from
Mar 25, 2020
Merged

rewrite: added conditional set-tag rule #3190

merged 2 commits into from
Mar 25, 2020

Conversation

vatsal-encs
Copy link
Contributor

fixes #1521

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

2 similar comments
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@alltilla
Copy link
Collaborator

@kira-syslogng ok to test

@kira-syslogng
Copy link
Contributor

Build SUCCESS

@alltilla
Copy link
Collaborator

Thanks for the PR! :)

Would you kindly add a newsfile entry as well?
https://github.com/syslog-ng/syslog-ng/blob/master/news/README.md

This change fits in the feature category.

@furiel furiel self-requested a review March 22, 2020 14:04
@kira-syslogng
Copy link
Contributor

Build SUCCESS

1 similar comment
@kira-syslogng
Copy link
Contributor

Build SUCCESS

alltilla
alltilla suggested changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, nearly there.

The news entry is perfect! :)

lib/rewrite/rewrite-expr-grammar.ym Outdated Show resolved Hide resolved
lib/rewrite/rewrite-expr-grammar.ym Show resolved Hide resolved
@kira-syslogng
Copy link
Contributor

Build SUCCESS

furiel
furiel suggested changes Mar 24, 2020
View reviewed changes
lib/rewrite/rewrite-expr-grammar.ym Outdated Show resolved Hide resolved
@kira-syslogng
Copy link
Contributor

Build SUCCESS

@alltilla alltilla merged commit 393678b into syslog-ng:master Mar 25, 2020
@vatsal-encs vatsal-encs deleted the conditional-set-tag branch March 26, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alltilla alltilla alltilla approved these changes

@furiel furiel furiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: conditional set-tag()
4 participants
@vatsal-encs @kira-syslogng @alltilla @furiel