Dbld readd centos6 support #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE |
furiel
reviewed
Aug 21, 2019
|
Is there a specific platform you test it on? Because I would include it
only there.
…On Wed, Aug 21, 2019, 08:33 furiel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dbld/images/helpers/pip_packages.manifest
<#2860 (comment)>:
> @@ -1,5 +1,4 @@
# pip packages for successful run unit tests
-hy [centos, fedora, debian, ubuntu]
Hy is used for internal testing, so the package is needed. Though we do
not test it on centos6. Is it possible to exclude only from centos6?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2860>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFOK5QSXCQW6VIMQT5HRQLQFTOVHANCNFSM4IJDVBDA>
.
|
This time of writing, only ubuntu xenial. Besides that, it might worth leaving in devshell too. |
bazsi
force-pushed
the
dbld-readd-centos6-support
branch
from
ac518fc
to
e8ea727
Compare
|
I have now rebased this work on the latest dbld-jenkinsfile branch.
With that rebase, I've limited the installation of "hy" in these images. |
|
Build SUCCESS |
bazsi
force-pushed
the
dbld-readd-centos6-support
branch
from
e8ea727
to
d0af535
Compare
|
Build SUCCESS |
bazsi
force-pushed
the
dbld-readd-centos6-support
branch
from
d0af535
to
0a20e32
Compare
|
rebased against current master. |
|
Build SUCCESS |
This reverts commit 896556d. Signed-off-by: Balazs Scheidler <[email protected]>
It does not seem to be used and fails to install on CentOS6 Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
bazsi
force-pushed
the
dbld-readd-centos6-support
branch
from
0a20e32
to
1f9fa88
Compare
|
Build SUCCESS |
gaborznagy
approved these changes
Nov 22, 2019
|
@kira-syslogng Build packages please. |
|
Package Build SUCCESS Packages are available at https://ci.syslog-ng.com/jenkins/job/kira-dbld-pull-requests/615/artifact/ |
furiel
reviewed
Nov 25, 2019
| centos-7) | ||
| python -m pip install --upgrade pip==9.0.3 | ||
| ;; | ||
| *) | ||
| python -m pip install --upgrade pip | ||
| ;; | ||
| esac | ||
| filter_packages_by_platform /helpers/pip_packages.manifest | xargs python -m pip install -U | ||
| filter_packages_by_platform /helpers/pip_packages.manifest | xargs pip install -U |
There was a problem hiding this comment.
Could you explain this change? Why do we need to use pip install instead of python -m pip install?
|
hi,
because it doesn't work with Python2.6
…On Mon, Nov 25, 2019 at 9:12 AM furiel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dbld/images/helpers/dependencies.sh
<#2860 (comment)>:
> centos-7)
python -m pip install --upgrade pip==9.0.3
;;
*)
python -m pip install --upgrade pip
;;
esac
- filter_packages_by_platform /helpers/pip_packages.manifest | xargs python -m pip install -U
+ filter_packages_by_platform /helpers/pip_packages.manifest | xargs pip install -U
Could you explain this change? Why do we need to use pip install instead
of python -m pip install?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2860?email_source=notifications&email_token=AAFOK5SAALRQIUY4HMYFIVTQVOCFFA5CNFSM4IJDVBDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMZMT4A#pullrequestreview-322095600>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFOK5TVPC7WR4Z5HOTTQTDQVOCFFANCNFSM4IJDVBDA>
.
--
Bazsi
|
furiel
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just recently someone was trying to compile/run syslog-ng on RHEL6, so albeit I've dropped support
for it in dbld, it is still in use. So I've decided to go back and understand why I've felt that it was so difficult to support. With our glib compat code, it turned out not that difficult, even though we had a lot of warnings.
With warnings fixed, this actually improves the code, so here it comes as a PR.I've added the bits independent of centos6 into a separate PR #2971.This depends on #2859 so putting it into WIP until that one is merged.Now all dependencies are in, so this is also ready to go in.