scrum-1195: Set menu structure. #133
Conversation
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:${portal/rezensionen/absolute_url}/rezensionen</property> |
There was a problem hiding this comment.
I see this contains rezensionen a couple of times.
Does it make sense to change it to:
| <property name="url_expr">string:${portal/rezensionen/absolute_url}/rezensionen</property> | |
| <property name="url_expr">portal/rezensionen/rezensionen/absolute_url</property> |
?
There was a problem hiding this comment.
Shouldn't it rather be string:${portal_url}/rezensionen/rezensionen ?
There was a problem hiding this comment.
I was proposing that form because you had in your original PR portal/rezensionen/absolute_url.
Do whatever you like, but be consistent.
Or just don't be and ignore this nitpicky comment
There was a problem hiding this comment.
${portal/rezensionen/absolute_url} was from the actions.xml export I did on the testing database from https://recensio50.fe.rzob.gocept.net/
But actually I didn't understand whey it was constructing the URL like that.
| <property name="description" | ||
| i18n:translate="" | ||
| /> | ||
| <property name="url_expr">string:${portal_url}/ueber-uns</property> |
There was a problem hiding this comment.
Will this work:
| <property name="url_expr">string:${portal_url}/ueber-uns</property> | |
| <property name="url_expr">portal/ueber-uns/absolute_url</property> |
?
There was a problem hiding this comment.
I don't think so - we do need ${portal_url}, no?
|
Did not much think about the migration process except that I think it would skip existing items. But I'm not convinced about this PR myself. |
This commit sets the recensio portal tabs menu explicitly via actions.xml which was apparently set manually before.
Also, it adds these Documents:
to reflect the old URL structure on https://www.recensio.net/
All of those Documents are set to have the layout "latest-review-items"
This solves scrum-1195.
However, I'm not 100% sold on this.
Some problems I see:
frtodewouldn't switch from/rezensionen/recensionsto/rezensionen/rezensionen.I'm not sure if there is a better solution. I'm open to suggestions.