Support for mocha 8.2.0 validateLegacyPlugin change #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BeeMargarida I see no reason to not support Mocha 8, our tests pass for Mocha 8 after minor tweaks: #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The new version of mocha (8.2.0) included a change that renamed the
validatePluginfunction tovalidateLegacyPlugin.Even though mochapack only supports mocha up to version 7, projects that use other dependencies that use recent versions of mocha override the mocha version of mochapack. This is a quick fix for the change.
How did you fix it?
Checks if the
validatePluginfunction is defined, if not, uses thevalidateLegacyPluginfunction.Not sure if this is the best solution, if not, I'm open to changes :)