🌱 Refactoring code for release candidate #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiskemper
force-pushed
the
refactor/release-code-refactoring
branch
4 times, most recently
from
0a389d5
to
2c3cb3a
Compare
- refactoring webhooks - adding capability of updating the loadbalancer's type, algorithm and name - allowing three different log levels, set by the log-level flag - removing context from clusterScope - Removing context and cancel function from cluster reconciler and using stop channels instead - Using the same options for target cluster manager as for normal manager - Replacing several nested for loops with maps - Minor changes
janiskemper
force-pushed
the
refactor/release-code-refactoring
branch
from
2c3cb3a
to
40952d6
Compare
batistein
added a commit
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
TODOs: