⚠️ Refactors loadbalancer target. Changes services to extraTarget. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batistein
force-pushed
the
feature/reconcile-lb-targets
branch
from
d11a9a7
to
19e6d91
Compare
Loadbalancer targets are now reconciled as well. Before they were not updated after load balancer creation. They can be both deleted and created - updating is not supported.
batistein
force-pushed
the
feature/reconcile-lb-targets
branch
from
19e6d91
to
1e27392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change Adds, removes, or changes an API
What this PR does / why we need it:
This PR changes the api for controlPlaneLoadBalancer in HetznerCluster. Now the first loadbalancer target is configured by only controlPlaneEndpoint.Port (listenPort) and controlPlaneLoadbalancer.Port (destinationPort). Additional loadbalancer target could be created by using extraTargets.
Additionally we are now defaulting controlPlaneLoadbalancer algorithm, type and port.