🌱 rename and document annotations. #1458

guettli · 2024-08-21T09:08:53Z

Fixes #1457

api/v1beta1/hetznerbaremetalhost_types.go

janiskemper

one suggestion. In general LGTM

docs/caph/03-reference/08-annotations.md

…plane-address

guettli added 4 commits August 21, 2024 11:07

🌱 rename and document annotations.

386e44c

Fixes #1457

... docs.

46f6185

spell checked.

f4a272e

.. docs.

b345ed1

guettli commented Aug 21, 2024

View reviewed changes

api/v1beta1/hetznerbaremetalhost_types.go Show resolved Hide resolved

... less diff to main.

474436d

guettli requested review from janiskemper and batistein August 21, 2024 10:09

removed tests for other reboot annotations.

121134a

batistein previously approved these changes Aug 21, 2024

View reviewed changes

🌱 add table

fca729c

buhodev dismissed batistein’s stale review via fca729c August 21, 2024 13:16

buhodev and others added 3 commits August 21, 2024 10:13

🌱 add individual tables

ee3d981

🌱 add hyphen to wipedisk string

0cec0a6

Merge branch 'main' into tg/update-annotion-strings-to-valid-schema

3b58e5d

guettli marked this pull request as ready for review August 22, 2024 09:17

syself-bot bot added area/code Changes made in the code directory area/api Changes made in the api directory labels Aug 22, 2024

janiskemper reviewed Aug 22, 2024

View reviewed changes

docs/caph/03-reference/08-annotations.md Outdated Show resolved Hide resolved

... simplified code and document capi.syself.com/allow-empty-control-…

23e775a

…plane-address

guettli requested a review from janiskemper August 23, 2024 06:53

syself-bot bot added the size/M Denotes a PR that changes 50-200 lines, ignoring generated files. label Aug 23, 2024

guettli requested a review from batistein August 23, 2024 07:12

batistein approved these changes Aug 23, 2024

View reviewed changes

guettli merged commit e95f4ae into main Aug 23, 2024
9 checks passed

guettli deleted the tg/update-annotion-strings-to-valid-schema branch August 23, 2024 07:25

Provide feedback