🌱 Remove permanent error after bm reboot #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the provisioning of bare metal servers, we added permanent errors that appear after a server times out while rebooting. This turned out to be quite unreliable, because the server reboots are very unreliable. Sometimes they take forever to reboot, in other situations they are fast and the server provisions successfully. Therefore, we should rather try again and not stop completely.
syself-bot
bot
added
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the provisioning of bare metal servers, we added permanent errors that appear after a server times out while rebooting.
This turned out to be quite unreliable, because the server reboots are very unreliable. Sometimes they take forever to reboot, in other situations they are fast and the server provisions successfully.
Therefore, we should rather try again and not stop completely.
TODOs: