🌱 Set providerID in phase ensure-provisioned #1351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
reviewed
Jun 17, 2024
Currently, we set the providerID of a baremetal server only after we confirmed that cloud init has successfully completed. However, CAPI also reacts on the result of cloud init, so there might be a temporary state when CAPI already reconciles the node object, CSRs are created, etc., but we have not yet set the providerID. This leads for example to errors in the csr-controller, where we rely on the providerID to be set. This PR sets the providerID already in ensure-provisioned state, so that these temporary errors should not occur anymore.
janiskemper
force-pushed
the
set-providerid
branch
from
7aa9fb8
to
5fbe39b
Compare
|
Just for the records, we cherry-picked this PR, and then the bm machines failed to join the cluster. |
|
This was merged instead: #1357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, we set the providerID of a baremetal server only after we confirmed that cloud init has successfully completed. However, CAPI also reacts on the result of cloud init, so there might be a temporary state when CAPI already reconciles the node object, CSRs are created, etc., but we have not yet set the providerID.
This leads for example to errors in the csr-controller, where we rely on the providerID to be set.
This PR sets the providerID already in ensure-provisioned state, so that these temporary errors should not occur anymore.
I think we will prefer this approach: #1357
TODOs: