🐛 Improve handling of bm server reboot timeouts #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
reviewed
Jun 5, 2024
guettli
approved these changes
Jun 19, 2024
syself-bot
bot
added
area/code
Bare metal servers currently can time out while rebooting. However, the timeouts don't make too much sense right now. - The timeout is too big, so that usually MachineHealthChecks will trigger before the timeout is reached. We reduce this here. - The server was just rebooted again if a timeout is reached. However, if the timeout is actually reached, we don't want to continue, as there is probably something wrong with the server. Now we set a permanent error. Additionally, there are some code improvements: - The check whether a reboot has been triggered requires an API call to Hetzner API. This check is now only done when necessary, so that we safe the unneccessary API calls. - We set a permanent error if a reboot is marked as failed, so that we stop reconciling. - The ProvisionSucceeded condition of a host is saved in case of a permanent error to give the user some feedback that the permanent error happened and why.
janiskemper
force-pushed
the
handle-reboot-timeout
branch
from
c298628
to
37e8b0b
Compare
syself-bot
bot
added
the
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bare metal servers currently can time out while rebooting. However, the timeouts don't make too much sense right now.
Additionally, there are some code improvements:
TODOs: