🌱 avoid redacting logs when running e2e tests #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syself-bot
bot
added
size/XS
|
can you explain this change? |
We were running a script to redact the token in
This commit avoids redacting logs after each spec. We still do it after the whole suite completes. |
kranurag7
force-pushed
the
kr/avoid-redacting-logs
branch
from
e87c5a4
to
e5ab20d
Compare
kranurag7
force-pushed
the
kr/avoid-redacting-logs
branch
from
e5ab20d
to
013d03a
Compare
janiskemper
approved these changes
May 7, 2024
We were running a script to redact the token in _artifacts directory which gets produced when we run our e2e tests. Since, ginkgo spec are run one after another, once first spec runs and we redact the logs, the manifest (kind: Secret) gets invalid and we get an error in our e2e tests. Error from server (BadRequest): error when creating "secret.yaml": Secret in version "v1" cannot be handled as a Secret: illegal base64 data at input byte 0 This commit avoids redacting logs after each spec. We still do it after the whole suite completes. Signed-off-by: kranurag7 <[email protected]>
kranurag7
force-pushed
the
kr/avoid-redacting-logs
branch
from
013d03a
to
0c2b05a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running a script to redact the token in _artifacts directory which gets produced when we run our e2e tests. Since, ginkgo spec are run one after another, once first spec runs and we redact the logs, the manifest (kind: Secret) gets invalid and we get an error in our e2e tests.
Error from server (BadRequest): error when creating "secret.yaml": Secret in version "v1" cannot be handled as a Secret: illegal base64 data at input byte 0This commit avoids redacting logs after each spec. We still do it after the whole suite completes.