Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ update to cluster API 1.7.1 #1281

Merged
merged 1 commit into from
May 7, 2024
Merged

✨ update to cluster API 1.7.1 #1281

merged 1 commit into from
May 7, 2024

Conversation

kranurag7
Copy link
Contributor

@kranurag7 kranurag7 commented Apr 28, 2024 •
edited
Loading

What this PR does / why we need it:

  • updates cluster API to 1.7.1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

janiskemper
janiskemper reviewed Apr 29, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@kranurag7 kranurag7 force-pushed the kr/update-capi-to-1-7-1 branch 3 times, most recently from 005cc59 to 42a4d7e Compare May 5, 2024 18:43
@syself-bot syself-bot bot added area/hack Changes made in the hack directory area/templates Changes made in the templates directory area/test Changes made in the test directory labels May 6, 2024
@kranurag7 kranurag7 force-pushed the kr/update-capi-to-1-7-1 branch 2 times, most recently from 70edbf8 to e54f87c Compare May 7, 2024 10:49
@kranurag7 kranurag7 marked this pull request as draft May 7, 2024 11:14
guettli
guettli reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the source and found that in the Makefile.

export KUBEBUILDER_ENVTEST_KUBERNETES_VERSION ?= 1.29.0

I guess 1.29.4 is needed here.

guettli
guettli previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kranurag7 kranurag7 force-pushed the kr/update-capi-to-1-7-1 branch 2 times, most recently from 0788ffc to 5ed2c7c Compare May 7, 2024 19:30
update to cluster API 1.7.1
44e61b8 
- this commit updates golang dependencies to
Cluster API 1.7.1 version.
- this commit uses kind node image from fluxcd repo
and we no longer kind image published on DockerHub at kindest/node.
- updates cluster templates and node images.
- this commit enables us to use 1.29.4 version while development
using Tilt and kind setup.
@kranurag7 kranurag7 marked this pull request as ready for review May 7, 2024 20:30
@kranurag7 kranurag7 merged commit 2a305e1 into main May 7, 2024
14 checks passed
@kranurag7 kranurag7 deleted the kr/update-capi-to-1-7-1 branch May 7, 2024 21:28
@kranurag7 kranurag7 mentioned this pull request May 8, 2024
Closed
3 tasks
@rbjorklin rbjorklin mentioned this pull request May 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiskemper janiskemper janiskemper approved these changes

@guettli guettli guettli left review comments

Assignees
No one assigned
Labels
area/hack Changes made in the hack directory area/templates Changes made in the templates directory area/test Changes made in the test directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kranurag7 @guettli @janiskemper