Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump to controller-gen 0.14.0 and check diff in CI #1221

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

kranurag7
Copy link
Contributor

@kranurag7 kranurag7 commented Mar 20, 2024

this commit bumps controller-gen to 0.14.0 for CAPH.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #851

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@kranurag7 kranurag7 requested a review from guettli March 20, 2024 11:16
guettli
guettli previously approved these changes Apr 4, 2024
Copy link
Contributor

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

this commit bumps controller-gen to 0.14.0 for CAPH.

Signed-off-by: kranurag7 <[email protected]>
@kranurag7 kranurag7 marked this pull request as ready for review April 5, 2024 05:46
@syself-bot syself-bot bot added area/github Changes made in the github directory area/hack Changes made in the hack directory area/api Changes made in the api directory labels Apr 5, 2024
@kranurag7
Copy link
Contributor Author

@guettli can you please approve this again?

@guettli guettli self-requested a review April 5, 2024 09:03
@guettli guettli merged commit 7d7d017 into main Apr 5, 2024
14 checks passed
@guettli guettli deleted the kr/controller-gen branch April 5, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory area/github Changes made in the github directory area/hack Changes made in the hack directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disaligned manifests generated by controller-gen
2 participants