🌱 handle case where rescue system can't be reached. #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syself-bot
bot
added
area/code
guettli
force-pushed
the
tg/better-err-msg-if-rescue-system-is-not-reachable
branch
from
97627fe
to
5cc76e0
Compare
syself-bot
bot
added
size/M
guettli
commented
Apr 23, 2024
guettli
force-pushed
the
tg/better-err-msg-if-rescue-system-is-not-reachable
branch
from
5b743d8
to
3aa8cd2
Compare
guettli
force-pushed
the
tg/better-err-msg-if-rescue-system-is-not-reachable
branch
from
3aa8cd2
to
e4e029f
Compare
|
Janis will merge this PR |
janiskemper
approved these changes
May 8, 2024
janiskemper
changed the title
janiskemper
deleted the
tg/better-err-msg-if-rescue-system-is-not-reachable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provide better err msg if rescue system can't be reached. Handle this case better, because currently it reaches and endless loop of hardware reboots if a bare metal server's rescue system is not reachable.
Additionally, the controller emits an Event for every reboot now. This makes it more clear what is happening.