-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Several small changes to make debugging bare-metal provisioning easier #1196
🌱 Several small changes to make debugging bare-metal provisioning easier #1196
Conversation
@janiskemper I started with a PR. This gets called for hbmhs which are in-use. But a hbmh which is not in-use seems to be ignored. I guess Reconcile() does not get called. |
@guettli we usually create draft PRs. Since your linting still fails because of spelling mistakes, I would have thought that a draft PR is more appropriate. |
The PR is a draft now. @janiskemper what about this: The conditions gets called for hbmhs which are in-use. But a hbmh which is not in-use seems to be ignored. I guess Reconcile() does not get called. Is it ok like this, or should the new method be called for hbmhs which are not in use, too? |
yes, definitely and especially for the ones that are not in use! |
846813d
to
7cfb6cc
Compare
7cfb6cc
to
f63b41f
Compare
f63b41f
to
d06dbde
Compare
What this PR does / why we need it:
Better logging: Show URL of machine image (with password of URL redacted).
Update filter-caph-controller-manager-logs.py to cut very long output.
Adapt detect-linux-on-another-disk.sh to work on Ubuntu 20.04 and on machines with empty disks (no partitions yet).
Create events for InstallingMachineImageStarted to provide better hints about what is going on (and easier way to see how long these steps take).