Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Several small changes to make debugging bare-metal provisioning easier #1196

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Mar 6, 2024

What this PR does / why we need it:

Better logging: Show URL of machine image (with password of URL redacted).

Update filter-caph-controller-manager-logs.py to cut very long output.

Adapt detect-linux-on-another-disk.sh to work on Ubuntu 20.04 and on machines with empty disks (no partitions yet).

Create events for InstallingMachineImageStarted to provide better hints about what is going on (and easier way to see how long these steps take).

@syself-bot syself-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/code Changes made in the code directory area/api Changes made in the api directory labels Mar 6, 2024
@guettli
Copy link
Contributor Author

guettli commented Mar 6, 2024

@janiskemper I started with a PR. This gets called for hbmhs which are in-use. But a hbmh which is not in-use seems to be ignored. I guess Reconcile() does not get called.

@janiskemper
Copy link
Contributor

@guettli we usually create draft PRs. Since your linting still fails because of spelling mistakes, I would have thought that a draft PR is more appropriate.

@guettli guettli marked this pull request as draft March 6, 2024 16:05
@guettli guettli closed this Mar 6, 2024
@guettli guettli reopened this Mar 6, 2024
@guettli
Copy link
Contributor Author

guettli commented Mar 6, 2024

@guettli we usually create draft PRs. Since your linting still fails because of spelling mistakes, I would have thought that a draft PR is more appropriate.

The PR is a draft now.

@janiskemper what about this:

The conditions gets called for hbmhs which are in-use. But a hbmh which is not in-use seems to be ignored. I guess Reconcile() does not get called.

Is it ok like this, or should the new method be called for hbmhs which are not in use, too?

@janiskemper
Copy link
Contributor

yes, definitely and especially for the ones that are not in use!

@guettli guettli changed the title 🌱 Condition for missing rootDeviceHints of HetznerBareMetalHost 🌱 Condition for missing rootDeviceHints, and many small changes. Mar 8, 2024
@guettli guettli marked this pull request as ready for review March 8, 2024 11:11
@guettli guettli requested a review from janiskemper March 8, 2024 11:11
@syself-bot syself-bot bot added area/hack Changes made in the hack directory size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-200 lines, ignoring generated files. labels Mar 8, 2024
@guettli guettli changed the title 🌱 Condition for missing rootDeviceHints, and many small changes. 🌱 Several small changes to make debugging bare-metal provisioning easier Mar 8, 2024
@guettli guettli force-pushed the tg/issue1174-conditions-for-missing-or-invalid-rootDeviceHints branch 2 times, most recently from 846813d to 7cfb6cc Compare March 8, 2024 12:22
janiskemper
janiskemper previously approved these changes Mar 8, 2024
@guettli guettli force-pushed the tg/issue1174-conditions-for-missing-or-invalid-rootDeviceHints branch from 7cfb6cc to f63b41f Compare March 8, 2024 12:27
@guettli guettli force-pushed the tg/issue1174-conditions-for-missing-or-invalid-rootDeviceHints branch from f63b41f to d06dbde Compare March 8, 2024 12:28
@janiskemper janiskemper merged commit 2b2d6f1 into main Mar 8, 2024
9 checks passed
@janiskemper janiskemper deleted the tg/issue1174-conditions-for-missing-or-invalid-rootDeviceHints branch March 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory area/code Changes made in the code directory area/hack Changes made in the hack directory size/XXL Denotes a PR that changes 2000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants