-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 update hetzner-baremetal guide #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sayanta66
force-pushed
the
caphdocss
branch
3 times, most recently
from
February 23, 2024 14:12
32e31ea
to
6af0352
Compare
Sayanta66
changed the title
📖 Updating the Quickstart guide of CAPH doc [WIP]
📖 Updating and revamping CAPH doc entirely [WIP]
Feb 26, 2024
guettli
reviewed
Feb 28, 2024
@janiskemper @kranurag7 - Can you both take a look at the new changes? |
kranurag7
force-pushed
the
caphdocss
branch
2 times, most recently
from
April 4, 2024 12:03
197b5d3
to
39bb9f6
Compare
janiskemper
reviewed
Apr 5, 2024
janiskemper
requested changes
Apr 8, 2024
janiskemper
requested changes
Apr 9, 2024
janiskemper
reviewed
Apr 9, 2024
looks good! |
Update hetznerbaremetalhost_types.go Signed-off-by: kranurag7 <[email protected]> Co-authored-by: janiskemper <[email protected]>
kranurag7
approved these changes
Apr 9, 2024
janiskemper
approved these changes
Apr 9, 2024
kranurag7
changed the title
📖 Updating and revamping CAPH doc entirely [WIP]
📖 update hetzner-baremetal guide
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Docs restructuring which includes the rewriting of the quickstart guide by means of addition and eliminations. Baremetal and node image contents are separated.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: