Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update hetznerbaremetalhost_types.go #1172

Merged
merged 2 commits into from
Mar 28, 2024
Merged

🌱 Update hetznerbaremetalhost_types.go #1172

merged 2 commits into from
Mar 28, 2024

Conversation

Sayanta66
Copy link
Contributor

What this PR does / why we need it:

Added spec descriptions and fixes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@syself-bot syself-bot bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/api Changes made in the api directory labels Feb 20, 2024
@Sayanta66 Sayanta66 marked this pull request as draft February 20, 2024 11:37
@syself-bot syself-bot bot added size/S Denotes a PR that changes 20-50 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. labels Feb 20, 2024
@Sayanta66 Sayanta66 marked this pull request as ready for review February 21, 2024 13:28
@syself-bot syself-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. and removed size/S Denotes a PR that changes 20-50 lines, ignoring generated files. labels Feb 29, 2024
@Sayanta66 Sayanta66 force-pushed the Sayanta66-patch-2 branch 2 times, most recently from fe55627 to 0a2302d Compare February 29, 2024 05:28
@kranurag7 kranurag7 marked this pull request as draft February 29, 2024 10:37
@Sayanta66 Sayanta66 force-pushed the Sayanta66-patch-2 branch 3 times, most recently from 9b25040 to 3a9ff6f Compare February 29, 2024 12:38
@kranurag7 kranurag7 marked this pull request as ready for review March 27, 2024 19:20
kranurag7
kranurag7 previously approved these changes Mar 27, 2024
@kranurag7 kranurag7 merged commit b8f6c72 into main Mar 28, 2024
9 checks passed
@kranurag7 kranurag7 deleted the Sayanta66-patch-2 branch March 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants