Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update hcloudmachine_types.go #1169

Merged
merged 1 commit into from
Feb 27, 2024
Merged

🌱 Update hcloudmachine_types.go #1169

merged 1 commit into from
Feb 27, 2024

Conversation

Sayanta66
Copy link
Contributor

What this PR does / why we need it:

Added descriptions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@syself-bot syself-bot bot added size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. area/api Changes made in the api directory labels Feb 19, 2024
api/v1beta1/hcloudmachine_types.go Outdated Show resolved Hide resolved
@janiskemper
Copy link
Contributor

thanks, you can squash

@Sayanta66
Copy link
Contributor Author

Updating a few more descriptions in line with our reference docs. Then will squash all the commits together.

api/v1beta1/hcloudmachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/hcloudmachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/hcloudmachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/hcloudmachine_types.go Outdated Show resolved Hide resolved
api/v1beta1/hcloudmachine_types.go Outdated Show resolved Hide resolved
@syself-bot syself-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. labels Feb 27, 2024
@Sayanta66 Sayanta66 force-pushed the sb/hcloudmachine branch 3 times, most recently from 5604e71 to 084da0b Compare February 27, 2024 07:30
Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an empty introduction.md file in this commit! You should remove it

Added descriptions
@Sayanta66
Copy link
Contributor Author

there is an empty introduction.md file in this commit! You should remove it

Done

@Sayanta66 Sayanta66 merged commit dc6a70a into main Feb 27, 2024
7 of 9 checks passed
@Sayanta66 Sayanta66 deleted the sb/hcloudmachine branch February 27, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Changes made in the api directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants