Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix ginkgo version mismatch #1114

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

kranurag7
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@kranurag7 kranurag7 marked this pull request as ready for review January 16, 2024 15:09
@syself-bot syself-bot bot added the area/test Changes made in the test directory label Jan 16, 2024
Copy link
Contributor

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Anurag, unfortunately there is still a version mismatch:

If I look at the e2e hcloud test, then I see in the raw logs this:

2024-01-16T15:11:44.2665871Z �[38;5;9m�[1mGinkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:�[0m
2024-01-16T15:11:44.2667711Z   Ginkgo CLI Version:
2024-01-16T15:11:44.2668676Z     �[1m2.7.1�[0m
2024-01-16T15:11:44.2669174Z   Mismatched package versions found:
2024-01-16T15:11:44.2670013Z     �[1m2.13.2�[0m used by e2e

raw logs of hcloud basic test

@kranurag7
Copy link
Contributor Author

Thomas, Locally I'm not able to reproduce it. If you run the make test-e2e-baremetal or any e2e tests locally then we are not getting version mismatched.

@guettli
Copy link
Contributor

guettli commented Jan 31, 2024

Thomas, Locally I'm not able to reproduce it. If you run the make test-e2e-baremetal or any e2e tests locally then we are not getting version mismatched.

@kranurag7

I see.

What does your change do? Does it solve that on your local device?

What can we do?

One thing which came to my mind: We could remove the actual tests in this PR (just for testing), so that the e2e finish immediately. This provides a better test-environment for you, because you don't need to wait that long.

Does this make sense to you, or do you have a different idea?

Overall it is not that important. But would be nice to have this fixed some day.

@guettli guettli self-requested a review March 4, 2024 11:17
@syself-bot syself-bot bot added the size/XS Denotes a PR that changes 0-20 lines, ignoring generated files. label Mar 4, 2024
Copy link
Contributor

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@kranurag7 kranurag7 force-pushed the kr/fix-ginkgo-version-mismatch branch from 4f421ac to aeadc33 Compare March 4, 2024 11:20
@kranurag7 kranurag7 merged commit 769847c into main Mar 6, 2024
8 checks passed
@kranurag7 kranurag7 deleted the kr/fix-ginkgo-version-mismatch branch March 6, 2024 10:31
guettli pushed a commit that referenced this pull request Mar 6, 2024
fix ginkgo version mismatch

Signed-off-by: Anurag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test Changes made in the test directory size/XS Denotes a PR that changes 0-20 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants