-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix ginkgo version mismatch #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anurag, unfortunately there is still a version mismatch:
If I look at the e2e hcloud test, then I see in the raw logs this:
2024-01-16T15:11:44.2665871Z �[38;5;9m�[1mGinkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:�[0m
2024-01-16T15:11:44.2667711Z Ginkgo CLI Version:
2024-01-16T15:11:44.2668676Z �[1m2.7.1�[0m
2024-01-16T15:11:44.2669174Z Mismatched package versions found:
2024-01-16T15:11:44.2670013Z �[1m2.13.2�[0m used by e2e
Thomas, Locally I'm not able to reproduce it. If you run the make test-e2e-baremetal or any e2e tests locally then we are not getting version mismatched. |
I see. What does your change do? Does it solve that on your local device? What can we do? One thing which came to my mind: We could remove the actual tests in this PR (just for testing), so that the e2e finish immediately. This provides a better test-environment for you, because you don't need to wait that long. Does this make sense to you, or do you have a different idea? Overall it is not that important. But would be nice to have this fixed some day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Signed-off-by: Anurag <[email protected]>
4f421ac
to
aeadc33
Compare
fix ginkgo version mismatch Signed-off-by: Anurag <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: