🌱 Removing unused load balancer properties in status & spec as well as refactoring reconcilement #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janiskemper
force-pushed
the
cleanup/loadbalancer
branch
from
4625d7a
to
3058079
Compare
batistein
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind api-change
/kind cleanup
What this PR does / why we need it:
Cleaning up load balancer API with removing ID from specs (wasn't used at all), as well as removing properties from status which are already defined in specs. Removing boolean
AttachedToNetworkand replacing it with conditions.Doing some clean-up work in the code.