Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add make generate-hcloud-token and bump versions #1046

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

kranurag7
Copy link
Contributor

this commit add new make target make generate-hcloud-token and bumps the version of some components in the Makefile.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
guettli
guettli previously approved these changes Nov 7, 2023
Copy link
Contributor

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Only one optional suggestion.

this commit add new make target `make generate-hcloud-token` and bumps
the version of some components in the Makefile.

Signed-off-by: Anurag <[email protected]>
@kranurag7 kranurag7 marked this pull request as ready for review November 8, 2023 11:37
@syself-bot syself-bot bot added the area/hack Changes made in the hack directory label Nov 8, 2023
@kranurag7 kranurag7 merged commit dddad7c into main Nov 9, 2023
4 checks passed
@kranurag7 kranurag7 deleted the kr/hcloud-token-make-target branch November 9, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hack Changes made in the hack directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants